Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds settings to control the visibility of comment and invited comment features #4365

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ajrbyers
Copy link
Member

This PR closes #3097

  • Adds two new settings to control visibility of comment and invited comment features
  • Adds a new decorator (with tests) that can check if a repository setting is enabled
  • Adds logic to the repository_preprint view to block comments when the feature is disabled

Comments block removed:
image

Manage Reviewers Removed:
image

Comments Controls Removed:
Screenshot 2024-08-13 at 15 27 24

@ajrbyers ajrbyers changed the title 3097 preprint comment visibility Adds settings to control the visibility of comment and invited comment features Aug 16, 2024
@ajrbyers
Copy link
Member Author

ajrbyers commented Aug 19, 2024

@ajrbyers ajrbyers self-assigned this Aug 19, 2024
@ajrbyers ajrbyers force-pushed the 3097-preprint-comment-visibility branch from cda4866 to cf80a8b Compare November 6, 2024 11:23
@ajrbyers ajrbyers requested a review from mauromsl November 6, 2024 11:24
@ajrbyers ajrbyers removed their assignment Dec 2, 2024
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work

@mauromsl mauromsl requested a review from joemull December 5, 2024 09:29
@mauromsl mauromsl self-requested a review December 5, 2024 09:29
@mauromsl mauromsl removed their assignment Dec 5, 2024
Copy link
Member

@joemull joemull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting conflicting migrations:

CommandError: Conflicting migrations detected; multiple leaf nodes in the migration graph: (0045_historicalrepository_display_public_metrics_and_more, 0045_historicalrepository_enable_comments_and_more in repository).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preprints: Add toggle setting for Comments, Invited Comments, and Registered Reviewers
3 participants