Initiatives search #109
Open
Initiatives search #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pecirep
force-pushed
the
55-initiatives-searchbar
branch
from
8d01a5e
to
b5e1b08
Compare
georgimld
reviewed
Oct 31, 2024
| sx={{ ...descriptionStyles, WebkitLineClamp: title?.length > 50 ? 1 : 2 }} | ||
| > | ||
| {summary} | ||
| {isLoading ? ( |
There was a problem hiding this comment.
Try using the CardSkeleton from PR#107
georgimld
reviewed
Oct 31, 2024
| @@ -18,10 +21,39 @@ export type ProjectProps = { | |||
| }; | |||
|
|
|||
| export const ProjectSection = ({ projects }: ProjectProps) => { | |||
| const [inputValue, setInputValue] = useState(''); | |||
| const [searchResults, setSearchResults] = useState<BasicProject[]>(); | |||
There was a problem hiding this comment.
Try creating a project-section-context to store: searchResults, isLoading, refetchProjects, etc
georgimld
reviewed
Oct 31, 2024
| export const ResponsiveSearchInput = (props: SearchInputProps) => { | ||
| const isWideScreen = useMediaQuery((theme: Theme) => theme.breakpoints.up('md')); | ||
|
|
||
| return isWideScreen ? <FullSearchInput {...props} /> : <MobileSearchInput {...props} />; |
There was a problem hiding this comment.
use the FullSearchInput as default (to avoid the layout shift)
georgimld
reviewed
Oct 31, 2024
|
|
||
| return ( | ||
| <> | ||
| <SecondaryIconButton |
There was a problem hiding this comment.
make sure the filter button is aligned well on mobile
georgimld
reviewed
Oct 31, 2024
| @@ -43,6 +43,33 @@ export const ProjectFragment = graphql( | |||
| [InnoUserFragment], | |||
| ); | |||
|
|
|||
| // search in title, summary, author, description.text, description.tags.tag | |||
| export const SearchProjectsQuery = graphql( | |||
There was a problem hiding this comment.
get query and request from PR#107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
reuses queries from #107 so probably makes sense to wait for it first.
I also centered the ApplyFilterButton for mobile.