search by SHA or DOI #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ a test would be good here. |
|
Humm this is more complicated than I thought. The dois look like 10.5072/zenodo.46 which we could capture with a route like /ideas/:prefix/:suffix but the .46 on the end is going to confuse and trigger the rails format selector I think. Not sure how to overcome that in a non hacky way. |
|
It's not possible just to grab everything below e.g. |
|
I think it must be. I think we need to override the content matchers for some urls. On Wed, Dec 17, 2014 at 6:10 AM, Lars Holm Nielsen
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a search by DOI if the search by SHA fails