Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8348610: GenShen: TestShenandoahEvacuationInformationEvent failed with setRegions >= regionsFreed: expected 1 >= 57 #558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link
Contributor

@satyenme satyenme commented Jan 30, 2025

Renaming ShenandoahEvacuationInformation.freedRegions to ShenandoahEvacuationInformation.freeRegions for clarity, and fixing incorrect assertion in TestShenandoahEvacuationInformationEvent.cpp

Tested with tier 1, tier 2, and tier 3 tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8348610: GenShen: TestShenandoahEvacuationInformationEvent failed with setRegions >= regionsFreed: expected 1 >= 57 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/558/head:pull/558
$ git checkout pull/558

Update a local copy of the PR:
$ git checkout pull/558
$ git pull https://git.openjdk.org/shenandoah.git pull/558/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 558

View PR using the GUI difftool:
$ git pr show -t 558

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/558.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant