-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8342570: gc.*.gcUntilOld() assumes that full gc always promotes objects to old generation in a generational heap #521
base: master
Are you sure you want to change the base?
Conversation
…jects to old generation in a generational heap
incorrectly placed one at ShenandoahHeap to ShenandoahGenerationalHeap as originally intended.
collectors can answer "true" to "promotes on full gc" as all objects are in a single generation (irrespective of what you name it).
👋 Welcome back ysr! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@ysramakrishna The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
@ysramakrishna This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Commenting to keep alive. I hope to resurrect this in the fullness of time. Leaving it as a zombie draft in the interim. Will be rebased to openjdk/jdk at that time. |
/issue JDK-8342570
Some gc's such as Generational Shenandoah may run in modes where we choose not to (ever) promote objects to the old generation. The tests do not need the assumption of eventual promotion of an object into the old generation in such cases and can be relaxed. A new WhiteBox API is queried by the tests to check for this.
Testing: Ran the tests with all the existing collectors. For existing collectors, there is no change in the tests. For Generational Shenandoah, being the only collector that does not necessarily promote objects to the old generation upon a full gc, we relax that requirement from the tests.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/521/head:pull/521
$ git checkout pull/521
Update a local copy of the PR:
$ git checkout pull/521
$ git pull https://git.openjdk.org/shenandoah.git pull/521/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 521
View PR using the GUI difftool:
$ git pr show -t 521
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/521.diff
Webrev
Link to Webrev Comment