Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8339644: Improve parsing of Day/Month in tzdata rules #615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dimitryc
Copy link
Contributor

@dimitryc dimitryc commented Jan 13, 2025

The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u-dev repo (April release).

The changes are the same as the changes proposed in openjdk/jdk8u#64 but now targeted to https://github.com/openjdk/jdk8u-dev


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339644 needs maintainer approval

Issue

  • JDK-8339644: Improve parsing of Day/Month in tzdata rules (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/615/head:pull/615
$ git checkout pull/615

Update a local copy of the PR:
$ git checkout pull/615
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/615/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 615

View PR using the GUI difftool:
$ git pr show -t 615

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/615.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2025

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 86a2f9c7dcb6585cabf03c0940511d11560e85b7 8339644: Improve parsing of Day/Month in tzdata rules Jan 13, 2025
@openjdk
Copy link

openjdk bot commented Jan 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 13, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 13, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant