8346887: DrawFocusRect() may cause an assertion failure

[satyenme]

Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8346887 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8346887: DrawFocusRect() may cause an assertion failure (Bug - P4 - Requested)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/614/head:pull/614
$ git checkout pull/614

Update a local copy of the PR:
$ git checkout pull/614
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 614

View PR using the GUI difftool:
$ git pr show -t 614

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/614.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[satyenme]

The GHA report several failures, all the failures unreleated to this PR (taken from this PR).

linux x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
linux x86 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
windows x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
windows x86 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
macos x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR.
macos x64 hotspot/tier1 compiler/unsafe/OpaqueAccesses.java test fails, which has been recorded by JDK-8337185, it's unreleated to this PR.

[mlbridge]

Webrevs

• 00: Full (687bf85e)

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[satyenme]

/approval request for backport. Minor change that adds an additional check before an assertion for windows. Tested with tier1 and pre-submit tests. Risk is low.

[openjdk]

@satyenme
8346887: The approval request has been created successfully.