8344916: RISC-V: Misaligned access in array fill stub #22347
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Please review this small change.
In
generate_fill
, we fill the remaining elements by a single 8-byte store when the remaining count is less than 8 bytes in size afterfill_words
. This may overwrite some elements and create misaligned access. While it's not an issue for mordern CPUs with fast misaligned access, this does affect performance on CPUs where misaligned access is emulated by a trap handler and thus is very slow. async-profiler tells 2.8% cpu cycles ofjshort_fill
in flame graph when sampling Specjbb2005 on these platforms.In this particular case, the copy address
to
is 8-byte aligned afterfill_words
. So ifAvoidUnalignedAccesses
is true, one choice would be directing control toL_fill_elements
which avoids alignment issue while filling the remaining elements.Test on linux-riscv64 platform:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22347/head:pull/22347
$ git checkout pull/22347
Update a local copy of the PR:
$ git checkout pull/22347
$ git pull https://git.openjdk.org/jdk.git pull/22347/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22347
View PR using the GUI difftool:
$ git pr show -t 22347
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22347.diff