Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344916: RISC-V: Misaligned access in array fill stub #22347

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Nov 24, 2024

Hi, Please review this small change.

In generate_fill, we fill the remaining elements by a single 8-byte store when the remaining count is less than 8 bytes in size after fill_words. This may overwrite some elements and create misaligned access. While it's not an issue for mordern CPUs with fast misaligned access, this does affect performance on CPUs where misaligned access is emulated by a trap handler and thus is very slow. async-profiler tells 2.8% cpu cycles of jshort_fill in flame graph when sampling Specjbb2005 on these platforms.

In this particular case, the copy address to is 8-byte aligned after fill_words. So if AvoidUnalignedAccesses is true, one choice would be directing control to L_fill_elements which avoids alignment issue while filling the remaining elements.

Test on linux-riscv64 platform:

  • tier1-3 (release)
  • 2.5% Specjbb2005 performance benefit on both HiFive Unmatched and Premier P550 SBCs.
  • No obvious performance impact witnessed on other platforms like BFI-F3 or Pioneer box.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344916: RISC-V: Misaligned access in array fill stub (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22347/head:pull/22347
$ git checkout pull/22347

Update a local copy of the PR:
$ git checkout pull/22347
$ git pull https://git.openjdk.org/jdk.git pull/22347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22347

View PR using the GUI difftool:
$ git pr show -t 22347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22347.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2024

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 24, 2024

@RealFYang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant