8344013: "bad tag in log" assert with +LogCompilation +CITimeVerbose

[SoniaZaldana]

Hi folks,

This PR addresses 8344013.

Sometimes the writing to xmlStream is mixed from several threads, and therefore the xmlStream tag stack can end up in a bad state. When this occurs, the VM crashes in xmlStream::pop_tag with assert(false) failed: bad tag in log.

In this case, running java -XX:+LogCompilation -XX:CompileCommand="log,*.*" -XX:+CITimeVerbose -Xcomp -Xbatch -version , xmlStream::pop_tag is expecting to pop the tag task but finds phase instead.

I found the issue stems from 8330157. The problematic code is in the destructor for TracePhase.

Note how the constructor adds the phase tag.

However, in the destructor, if we return early, we don’t pop that tag, leading to the xmlStream tag stack to end up in a bad state. With this patch, I made sure we pop the tag even if we return early.

Cheers,
Sonia

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344013: "bad tag in log" assert with +LogCompilation +CITimeVerbose (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22331/head:pull/22331
$ git checkout pull/22331

Update a local copy of the PR:
$ git checkout pull/22331
$ git pull https://git.openjdk.org/jdk.git pull/22331/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22331

View PR using the GUI difftool:
$ git pr show -t 22331

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22331.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@SoniaZaldana The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2725d240)