Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344865: SM cleanup in sun/reflect/annotation #22328

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Nov 22, 2024

Refactored doPrivileged and removed imports in sun.reflect.annotation classes:
AnnotationInvocationHandler, AnnotationParser, AnnotationSupport, and AnnotationType.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344865: SM cleanup in sun/reflect/annotation (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22328/head:pull/22328
$ git checkout pull/22328

Update a local copy of the PR:
$ git checkout pull/22328
$ git pull https://git.openjdk.org/jdk.git pull/22328/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22328

View PR using the GUI difftool:
$ git pr show -t 22328

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22328.diff

Using Webrev

Link to Webrev Comment

Refactored doPrivileged and removed imports
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344865: SM cleanup in sun/reflect/annotation

Reviewed-by: liach, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • d00f311: 8343150: Change URLClassLoader.getPermissions to return empty PermissionCollection
  • effee12: 8344533: CTW: Add option to remove clinits before loading
  • 70c4e2c: 8344587: Reduce number of "jdk.jpackage.internal" classes used from other packages
  • 1114704: 6672644: JComboBox still scrolling if switch to another window and return back
  • 98b6678: 8343741: SA jstack --mixed should print information about VM locks
  • 1b2d9ca: 8344881: Problemlist java/awt/Robot/InfiniteLoopException.java on Linux
  • 6aec2dc: 8344788: Specify that the access control context parameters of Subject.doAsPrivileged are ignored
  • 079f503: 8344568: Renaming ceil_log2 to log2i_ceil
  • 51763b6: 8344525: Fix leftover ExceptionOccurred in java.base
  • 4b16530: 8344795: Remove uses of AccessControlContext in java.desktop module
  • ... and 25 more: https://git.openjdk.org/jdk/compare/93d4ad4dd4cc4c5700af3453cfb3e21a804c8c14...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Nov 22, 2024

Webrevs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright year

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 22, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 22, 2024
Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this trivial update. Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants