-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8344865: SM cleanup in sun/reflect/annotation #22328
base: master
Are you sure you want to change the base?
8344865: SM cleanup in sun/reflect/annotation #22328
Conversation
Refactored doPrivileged and removed imports
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 35 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@RogerRiggs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright year
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this trivial update. Looks good.
Refactored doPrivileged and removed imports in sun.reflect.annotation classes:
AnnotationInvocationHandler, AnnotationParser, AnnotationSupport, and AnnotationType.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22328/head:pull/22328
$ git checkout pull/22328
Update a local copy of the PR:
$ git checkout pull/22328
$ git pull https://git.openjdk.org/jdk.git pull/22328/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22328
View PR using the GUI difftool:
$ git pr show -t 22328
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22328.diff
Using Webrev
Link to Webrev Comment