Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bytecode generation for invocation of varArg method #272

Open
wants to merge 6 commits into
base: code-reflection
Choose a base branch
from

Conversation

mabbay
Copy link
Member

@mabbay mabbay commented Nov 6, 2024

Support bytecode generation for invocation of varArg method.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/272/head:pull/272
$ git checkout pull/272

Update a local copy of the PR:
$ git checkout pull/272
$ git pull https://git.openjdk.org/babylon.git pull/272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 272

View PR using the GUI difftool:
$ git pr show -t 272

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/272.diff

Using Webrev

Link to Webrev Comment

@mabbay mabbay requested a review from asotona November 6, 2024 10:43
@mabbay mabbay self-assigned this Nov 6, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2024

👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Support bytecode generation for invocation of varArg method

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the code-reflection branch:

  • 18627a6: Move code reflection API into incubating module
  • 86dfc36: Aggregated work on Verifier and BytecodeLift deconstruction
  • a40e0f2: Simplify Interpreter invocation
  • 1d23ceb: Support conversions of primitives in testing context

Please see this link for an up-to-date comparison between the source branch of this pull request and the code-reflection branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 6, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2024

Webrevs

@@ -1560,6 +1560,15 @@ public List<Value> varArgOperands() {
return operands().subList(operandCount - varArgCount, operandCount);
}

public List<Value> argOperands() {
if (!isVarArgs()){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!isVarArgs()){
if (!isVarArgs) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants