-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bytecode generation for invocation of varArg method #272
base: code-reflection
Are you sure you want to change the base?
Conversation
👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into |
@mabbay This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java
Outdated
Show resolved
Hide resolved
src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java
Show resolved
Hide resolved
src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java
Outdated
Show resolved
Hide resolved
@@ -1560,6 +1560,15 @@ public List<Value> varArgOperands() { | |||
return operands().subList(operandCount - varArgCount, operandCount); | |||
} | |||
|
|||
public List<Value> argOperands() { | |||
if (!isVarArgs()){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!isVarArgs()){ | |
if (!isVarArgs) { |
Support bytecode generation for invocation of varArg method.
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/272/head:pull/272
$ git checkout pull/272
Update a local copy of the PR:
$ git checkout pull/272
$ git pull https://git.openjdk.org/babylon.git pull/272/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 272
View PR using the GUI difftool:
$ git pr show -t 272
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/272.diff
Using Webrev
Link to Webrev Comment