Changes for new release #468
Open
+4,716
−8,828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create PH file for Namibia, based on input from
Added both PH and SH Based on the file for Belgium
- Add missing process import - Sort imports - Replace 'prettier' by internal function - Add console output
KristjanESPERANTO
force-pushed
the
develop
branch
from
e62e98f to
2d28f1c
Compare
Running `npm run test-quick`complained about that.
KristjanESPERANTO
force-pushed
the
develop
branch
from
f52edbf to
9b1f4ba
Compare
|
I think it's more than enough for a release now. Let me know if you don't like anything. |
KristjanESPERANTO
force-pushed
the
develop
branch
from
9b1f4ba to
7368dc3
Compare
KristjanESPERANTO
force-pushed
the
develop
branch
from
3ca2074 to
fa80bed
Compare
KristjanESPERANTO
force-pushed
the
develop
branch
from
45cf661 to
c501c39
Compare
- js-yaml' development seems to be dead (no release for years, many open PRs and issues) - yaml' is actively maintained and more modern (ESM)
KristjanESPERANTO
force-pushed
the
develop
branch
from
2f3ba59 to
2b93ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #341, I have collected changes for the next release here.
My goal for the next release is to take care of low-hanging fruits first. This mainly includes adopting existing easy-to-understand PRs, updating the toolchain a bit and fixing small flaws found along the way.
Major changes and handling reported issues I would plan for after the next release. Steps like these are what I would consider major changes:
I will leave comments on some of the commits here:
Merged PRs
Solved issues
Not merged PRs
🎆 Running CI with maintained node versions 82d534a
I had to update
huskyand reworkci.ymlfor this.🐞 Fix 'yamlToJson.mjs' 2d28f1c
Side note: I don't know where the script is used. I noticed during the review that it uses prettier and that prettier is not in the package.json.
Nits
There are some nits like
Thoughts
After some work on this PR, I think it would have been clearer if I had written my additional changes in separate PRs and used this one as a collector for them.