Add Scotland and Northern Ireland public holidays #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've added public holiday definitions for Scotland and Northern Ireland following the existing examples.
When creating these, I ran into a couple of things I wasn't sure how to deal with. These may be larger issues which could be saved for a different pull request.
nextMo-Fr17March
syntax). However I would have expected it to occur for every holiday (including Christmas, etc.). In this pull request I decided to follow the existing examples and leave the Christmas/New Year ones as fixed dates but add the other variable ones correctly shifting to the next available Monday.