Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese Mainland PH #406

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

SierraIm
Copy link

@SierraIm SierraIm commented Aug 8, 2021

No description provided.

src/holidays/cn.yaml Outdated Show resolved Hide resolved
src/holidays/cn.yaml Outdated Show resolved Hide resolved
@LaoshuBaby
Copy link

所以清明节和中秋节的问题,有合适的解决方法吗?

@Artoria2e5
Copy link

Artoria2e5 commented Aug 11, 2021

应该和复活节的处理类似,有个 variable_date 指定名字,然后进 js 描述这个名字的 variable_date 怎么计算。见

function getMovableEventsForYear(year) {

我建议这些东西先留个注释以后再实现,因为农历比较难算。清明的话用春分加15算不难,但是要改 js 还是麻烦。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants