-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linting errors in config package and related files #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollback Files For Sweep
|
Apply Sweep Rules to your PR?
|
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Oct 19, 2023
This issue is stale because it has been open 60 days with no activity. |
kubbot
added
the
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
label
Jan 8, 2024
This PR was closed because it has been stalled for 7 days with no activity. You can reopen it if you want. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
Description
This PR fixes linting errors that occur when running the
make lint
command in the chat repository. The errors were caused by syntax issues in theconfig.go
,im.go
, andparse.go
files of thepkg/common/config
package. Additionally, the linting errors affected other files that import theconfig
package, includingcmd/api/admin-api/main.go
,cmd/api/chat-api/main.go
,cmd/rpc/admin-rpc/main.go
,cmd/rpc/chat-rpc/main.go
, andtools/component/component.go
.Summary of Changes
config.go
,im.go
, andparse.go
files of thepkg/common/config
package.cmd/api/admin-api/main.go
,cmd/api/chat-api/main.go
,cmd/rpc/admin-rpc/main.go
,cmd/rpc/chat-rpc/main.go
, andtools/component/component.go
to import the fixedconfig
package.make lint
command.Please review and merge this PR to fix the linting errors in the chat repository.
Fixes #233.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: