-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LinkedIn issuer. #2162
Update LinkedIn issuer. #2162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, @DovydasNavickas ❤️
@@ -1004,7 +1004,7 @@ | |||
|
|||
<Provider Name="LinkedIn" Id="eb3bc226-ed25-4258-8a37-2bfcc4d628a2" | |||
Documentation="https://learn.microsoft.com/en-us/linkedin/consumer/integrations/self-serve/sign-in-with-linkedin-v2"> | |||
<Environment Issuer="https://www.linkedin.com/" | |||
<Environment Issuer="https://www.linkedin.com/oauth" | |||
ConfigurationEndpoint="https://www.linkedin.com/oauth/.well-known/openid-configuration"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since LinkedIn now uses https://www.linkedin.com/oauth
as the issuer, we can remove the ConfigurationEndpoint
node 😃
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationProviders.xml
Show resolved
Hide resolved
Merged, thanks for your contribution, @DovydasNavickas! I'll backport it to the 5.7 branch and release a 5.7.1 version later today. |
It seems that LinkedIn has updated their issuer:
https://www.linkedin.com/oauth/.well-known/openid-configuration
And now LinkedIn provider gives an error:
The most important line is:
If I understand correctly, the only update needed is the Issuer in
OpenIddictClientWebIntegrationProviders.xml
.