Add download attribute to download links #407
Conversation
Fixes #405 Signed-off-by: Kai Kreuzer <[email protected]>
| </div> | ||
| </div> | ||
| <div v-if="selectedVersion === 'snapshot'"> | ||
| <div class="download-button-container"> | ||
| <a class="download-button" style="margin-bottom: 0" :href="`https://ci.openhab.org/job/openHAB-Distribution/lastSuccessfulBuild/artifact/distributions/openhab-addons/target/openhab-addons-4.0.0-SNAPSHOT.kar`">Download openHAB {{$page.frontmatter.currentSnapshotVersion}} Add-ons</a> | ||
| <a class="download-button" style="margin-bottom: 0" :href="`https://ci.openhab.org/job/openHAB-Distribution/lastSuccessfulBuild/artifact/distributions/openhab-addons/target/openhab-addons-4.0.0-SNAPSHOT.kar`" download>Download openHAB {{$page.frontmatter.currentSnapshotVersion}} Add-ons</a> |
There was a problem hiding this comment.
download="openhab-addons.kar">
That value should then be used as a suggestion for the browser. See attribute at the very bottom
There was a problem hiding this comment.
This would make it loose the version number in the name. The filename attribute is optional.
Can you confirm that the current version still does not work for you?
There was a problem hiding this comment.
I don't mind if you add the version number again, but I think the attribute needs to be filled so download has any effect at all.
In #405 I posted a screenshot which shows the issue is still there
Maybe like this?
download="openhab-addons-4.0.0-SNAPSHOT.kar">
| </div> | ||
| </div> | ||
| <div v-if="selectedVersion === 'snapshot'"> | ||
| <div class="download-button-container"> | ||
| <a class="download-button" style="margin-bottom: 0" :href="`https://ci.openhab.org/job/openHAB-Distribution/lastSuccessfulBuild/artifact/distributions/openhab-addons/target/openhab-addons-4.0.0-SNAPSHOT.kar`">Download openHAB {{$page.frontmatter.currentSnapshotVersion}} Add-ons</a> | ||
| <a class="download-button" style="margin-bottom: 0" :href="`https://ci.openhab.org/job/openHAB-Distribution/lastSuccessfulBuild/artifact/distributions/openhab-addons/target/openhab-addons-4.0.0-SNAPSHOT.kar`" download>Download openHAB {{$page.frontmatter.currentSnapshotVersion}} Add-ons</a> |
There was a problem hiding this comment.
| <a class="download-button" style="margin-bottom: 0" :href="`https://ci.openhab.org/job/openHAB-Distribution/lastSuccessfulBuild/artifact/distributions/openhab-addons/target/openhab-addons-4.0.0-SNAPSHOT.kar`" download>Download openHAB {{$page.frontmatter.currentSnapshotVersion}} Add-ons</a> | |
| <a class="download-button" style="margin-bottom: 0" :href="`https://ci.openhab.org/job/openHAB-Distribution/lastSuccessfulBuild/artifact/distributions/openhab-addons/target/openhab-addons-4.0.0-SNAPSHOT.kar`" download="openhab-addons-{{$page.frontmatter.currentSnapshotVersion}}.kar">Download openHAB {{$page.frontmatter.currentSnapshotVersion}} Add-ons</a> |
We could add the version dynamically too, so attribute would be used completely and the version still would be included.
There was a problem hiding this comment.
That works for the snapshot link, but the stable/milestone links are inserted dynamically - this would a bit more scripting to get it right...
There was a problem hiding this comment.
Then we should directly add additional methods for the different download file names right away.
Please leave the naming part out for now and merge it without the optional filename in the attribute..
I will take care of setting up proper names and assign me to the issue.
Reference #405