Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update alexa range value attribute parameters #2296

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Update alexa range value attribute parameters #2296

merged 1 commit into from
Jan 30, 2024

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Jan 30, 2024

@jsetton jsetton requested a review from a team as a code owner January 30, 2024 01:18
@relativeci RelativeCI
Copy link

relativeci bot commented Jan 30, 2024

Job #1387: Bundle Size — 15.93MiB (+0.04%).

9760294(current) vs 6ea38c3 main#1386(baseline)

Warning

Bundle contains 16 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1387		      Baseline
Job #1386
No change  Initial JS 1.81MiB 1.81MiB
No change  Initial CSS 608.39KiB 608.39KiB
Change  Cache Invalidation 94.01% 93.98%
No change  Chunks 217 217
No change  Assets 683 683
No change  Modules 3078 3078
No change  Duplicate Modules 236 236
No change  Duplicate Code 1.73% 1.73%
No change  Packages 152 152
No change  Duplicate Packages 16 16
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
Job #1387		      Baseline
Job #1386
Regression  JS 9.37MiB (+0.04%) 9.36MiB
Regression  Other 4.78MiB (+0.05%) 4.78MiB
Not changed  CSS 863.61KiB 863.61KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1387 report View jsetton:alexa-range-value-params branch activity View project dashboard

florian-h05
florian-h05 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 30, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Jan 30, 2024
@florian-h05 florian-h05 merged commit 424e646 into openhab:main Jan 30, 2024
6 checks passed
@jsetton jsetton deleted the alexa-range-value-params branch January 30, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jsetton @florian-h05