Make label optional in command items #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See openhab#803 Signed-off-by: Dan Cunningham <[email protected]>
|
Just for my understanding: Why is the same sitemap working with iOS app v1? |
|
its not, user's who install the updated V1 we just released are having the same issue. The problem is the coding data deserialization fails b/c label is not present for some users. |
|
Got it. Will you also backport the fix to the V1 version? |
|
For sure! Just waiting to verify this works for people. |
digitaldan
added a commit
to digitaldan/openhab.ios
that referenced
this pull request
Sep 12, 2024
cherry-pick 46c3610 Signed-off-by: Dan Cunningham <[email protected]>
digitaldan
added a commit
that referenced
this pull request
Sep 12, 2024
cherry-pick 46c3610 Signed-off-by: Dan Cunningham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #803