translate f7 underscores into iconify style dashes #754
Conversation
f7 icons use underscores. When they're imported into iconify, the underscores became dashes. When user actually specified f7:icon_name it should work without them having to know that we implemented it with iconify. Alternatively users can use iconify:f7:icon-name with dashes. If they had specified f7:icon-name that would still to work too Signed-off-by: Cody Cutrer <[email protected]>
|
@digitaldan: after you merge this, can you build a new beta build? the last one expired yesterday... 🤞 @timbms will have figured out the App Store build before it expires next time |
|
Hi , we submitted over the weekend, it was approved yesterday. We had to temporarily pull the watch app, Apple has not figured out why our watch ID has disappeared and is working on it internally, until then we can't really push to the app store for an official build. When this is merged i'll do a new build and push to test flight manually. I don't want to check in the changes to remove the watch target for deployment, xcode changes a lot of files and i worry about getting the target back in without a ton of headache. |
|
Oh awesome! Thank you! (I'm not really dependent on this change, so don't worry about getting this into TestFlight or the App Store for my benefit. I'll be happy just to have the other icon stuff in an official build). |
f7 icons use underscores. When they're imported into iconify, the underscores became dashes.
When user actually specified f7:icon_name it should work without them having to know that we implemented it with iconify.
Alternatively users can use iconify:f7:icon-name with dashes.
If they had specified f7:icon-name that would still to work too
See also openhab/openhab-android#3603