Improve on formatting issue #752 #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAKeanice
force-pushed
the
752-number_format_allow_strings
branch
3 times, most recently
from
b24ad69 to
f38a862
Compare
Signed-off-by: Tassilo Karge <[email protected]>
TAKeanice
force-pushed
the
752-number_format_allow_strings
branch
from
f38a862 to
c448ea7
Compare
TAKeanice
changed the title
|
@TAKeanice thank you for your bug fix! This is a great initiative. |
Used the clamped function for Comparable Signed-off-by: Tim Bert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the app there are crashes due to formatting issues.
Reason: Java placeholders (https://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html#syntax) as intended to be used by the OpenHab Sitemap specification (https://www.openhab.org/docs/configuration/items.html#state-presentation) were used in String.format in Swift, which uses the CString format specifiers (https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFStrings/formatSpecifiers.html).
The solution adds support for the %s format specifier. In the future, a java-placeholder-compatible format method should be introduced.