-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Added nginx web socket configuration #2437
base: main
Are you sure you want to change the base?
Conversation
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
To get the nginx proxy working with web sockets, e.g. to use the new log viewer in the OH4 GUI, the proxy_http_version 1.1 and the connectiond upgrade headers were added to the nginx configuration Signed-off-by: Frank Seidinger <[email protected]>
I've added HTTP/1.1 to openHABian's default nginx config, but I have not tested it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change, other than this LGTM.
@@ -39,6 +39,9 @@ server { | |||
listen 80; | |||
server_name mydomain_or_myip; | |||
|
|||
# Enable web sockets, e.g. used by the log viewver in the new OH4 GUI | |||
proxy_http_version 1.1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn’t need to be set here, already set in the location block below, please revert.
To get the nginx proxy working with web sockets, e.g. to use the new log viewer in the OH4 GUI, the proxy_http_version 1.1 was added to the nginx configuration.
For hints see Openhab 4.x and log viewer behind nginx proxy