Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Added nginx web socket configuration #2437

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FSeidinger
Copy link

To get the nginx proxy working with web sockets, e.g. to use the new log viewer in the OH4 GUI, the proxy_http_version 1.1 was added to the nginx configuration.

For hints see Openhab 4.x and log viewer behind nginx proxy

Copy link

netlify bot commented Dec 30, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 8433148
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/6772912943469300087aecea
😎 Deploy Preview https://deploy-preview-2437--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FSeidinger FSeidinger changed the title doc: Added web socket doc: Added nginx web socket configuration Dec 30, 2024
To get the nginx proxy working with web sockets, e.g. to use the new log viewer in the OH4 GUI, the proxy_http_version 1.1 and the connectiond upgrade headers were added to the nginx configuration

Signed-off-by: Frank Seidinger <[email protected]>
@stefan-hoehn
Copy link
Contributor

@mstormi @ecdye Do you mind reviewing the content from your experience?

@mstormi
Copy link
Contributor

mstormi commented Dec 31, 2024

I've added HTTP/1.1 to openHABian's default nginx config, but I have not tested it.
So I cannot comment if that works hence I won't.

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, other than this LGTM.

@@ -39,6 +39,9 @@ server {
listen 80;
server_name mydomain_or_myip;

# Enable web sockets, e.g. used by the log viewver in the new OH4 GUI
proxy_http_version 1.1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t need to be set here, already set in the location block below, please revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants