-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 21 for OH5 development #2426
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Holger Friedrich <[email protected]>
@florian-h05 @kaikreuzer |
✅ Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -46,6 +46,8 @@ You should probably do your usual OS backup too to make sure you can get back to | |||
|
|||
openHAB (since version 4) requires Java 17. Most modern Linux OS have an `openjdk-17-jdk` package available for you to install but alternative solutions such as [Zulu's OpenJDK](https://www.azul.com/downloads/zulu-community/?version=java-17-lts&package=jdk) (which openHABian can install for you) are available and these may run faster on 32-bit armhf platforms such as the Raspberry Pi. | |||
|
|||
Upcoming openHAB 5 development requires Java 21. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to not use the word "upcoming" so we don't have to come back to this later when it's no longer upcoming? And I guess also "development" can be omitted, since this page is about migration? Looking at the sentence above, maybe:
Upcoming openHAB 5 development requires Java 21. | |
openHAB 5 requires Java 21. |
?
(the sentence above regarding Java 17 for openHAB 4 might also need an update, but this is unrelated to your changes)
OpenHABian can install Java 21, but only on the native 64-bit image. | ||
Please note that versions of Java other than 17 and 21 are not supported at the moment. | ||
|
||
Upcoming openHAB 5 will require Java 21. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be slightly rephrased to follow the same phasing as in line 44 (and dropping "upcoming"):
Upcoming openHAB 5 will require Java 21. | |
Java 21 is required for openHAB 5.x series. |
@@ -41,10 +41,11 @@ You could also [download Azul Zulu](https://www.azul.com/downloads/zulu-communit | |||
Oracle Java is also suitable for most configurations but it's not recommended. Licensing restrictions may apply. | |||
|
|||
::: warning | |||
Java 17 is recommended for openHAB. | |||
Using Java 21 is possible, but still considered experimental. | |||
Java 17 is recommended for openHAB 4.x series. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java 17 is recommended for openHAB 4.x series. | |
Java 17 is required for openHAB 4.x series. |
(to complicate it, 4.3 specifically also supports Java 21, don't know if worth mentioning here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, I would prefer to not speak about openHAB 5 in the future as these docs are the development docs which now target openHAB 5 snapshot.
@@ -34,7 +34,7 @@ When installing Zulu or Zulu Embedded from a .zip or .tar archive, make sure to | |||
|
|||
::: tip Note | |||
Make sure to download Zulu or Java **17**. | |||
Using Java 21 is possible, but still considered experimental. | |||
Using Java 21 is possible, and will be required for openHAB 5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Java 21 is possible, and will be required for openHAB 5. | |
Using Java 21 is possible, and required for openHAB 5. |
OpenHABian can install Java 21, but only on the native 64-bit image. | ||
Please note that versions of Java other than 17 and 21 are not supported at the moment. | ||
|
||
Upcoming openHAB 5 will require Java 21. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upcoming openHAB 5 will require Java 21. | |
openHAB 5 requires Java 21. |
@@ -46,6 +46,8 @@ You should probably do your usual OS backup too to make sure you can get back to | |||
|
|||
openHAB (since version 4) requires Java 17. Most modern Linux OS have an `openjdk-17-jdk` package available for you to install but alternative solutions such as [Zulu's OpenJDK](https://www.azul.com/downloads/zulu-community/?version=java-17-lts&package=jdk) (which openHABian can install for you) are available and these may run faster on 32-bit armhf platforms such as the Raspberry Pi. | |||
|
|||
Upcoming openHAB 5 development requires Java 21. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upcoming openHAB 5 development requires Java 21. | |
openHAB 5 development requires Java 21. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #2426 (comment)
let me know when you want to have this merged. @mstormi @ecdye |
I will rework this once I find some time. It should have been added before we released 4.3.... @stefan-hoehn Maybe we should have pinned this forum post.... |
You mean, pin it in the forum? Yep, would be good idea. I think only a discourse admin can do it, AFAIK. |
Not sure if I managed to change it in all locations, but a first try...