Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 21 for OH5 development #2426

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

holgerfriedrich
Copy link
Member

Not sure if I managed to change it in all locations, but a first try...

Signed-off-by: Holger Friedrich <[email protected]>
@holgerfriedrich
Copy link
Member Author

holgerfriedrich commented Dec 15, 2024

@florian-h05 @kaikreuzer
We probably need something like this in the official 4.3 docs as well to avoid confusion.
Sorry, I missed that until now.

Copy link

netlify bot commented Dec 15, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 2512d0e
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/675f416aa9617800088a71d4
😎 Deploy Preview https://deploy-preview-2426--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -46,6 +46,8 @@ You should probably do your usual OS backup too to make sure you can get back to

openHAB (since version 4) requires Java 17. Most modern Linux OS have an `openjdk-17-jdk` package available for you to install but alternative solutions such as [Zulu's OpenJDK](https://www.azul.com/downloads/zulu-community/?version=java-17-lts&package=jdk) (which openHABian can install for you) are available and these may run faster on 32-bit armhf platforms such as the Raspberry Pi.

Upcoming openHAB 5 development requires Java 21.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to not use the word "upcoming" so we don't have to come back to this later when it's no longer upcoming? And I guess also "development" can be omitted, since this page is about migration? Looking at the sentence above, maybe:

Suggested change
Upcoming openHAB 5 development requires Java 21.
openHAB 5 requires Java 21.

?

(the sentence above regarding Java 17 for openHAB 4 might also need an update, but this is unrelated to your changes)

OpenHABian can install Java 21, but only on the native 64-bit image.
Please note that versions of Java other than 17 and 21 are not supported at the moment.

Upcoming openHAB 5 will require Java 21.
Copy link
Contributor

@jlaur jlaur Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be slightly rephrased to follow the same phasing as in line 44 (and dropping "upcoming"):

Suggested change
Upcoming openHAB 5 will require Java 21.
Java 21 is required for openHAB 5.x series.

@@ -41,10 +41,11 @@ You could also [download Azul Zulu](https://www.azul.com/downloads/zulu-communit
Oracle Java is also suitable for most configurations but it's not recommended. Licensing restrictions may apply.

::: warning
Java 17 is recommended for openHAB.
Using Java 21 is possible, but still considered experimental.
Java 17 is recommended for openHAB 4.x series.
Copy link
Contributor

@jlaur jlaur Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Java 17 is recommended for openHAB 4.x series.
Java 17 is required for openHAB 4.x series.

(to complicate it, 4.3 specifically also supports Java 21, don't know if worth mentioning here)

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, I would prefer to not speak about openHAB 5 in the future as these docs are the development docs which now target openHAB 5 snapshot.

@@ -34,7 +34,7 @@ When installing Zulu or Zulu Embedded from a .zip or .tar archive, make sure to

::: tip Note
Make sure to download Zulu or Java **17**.
Using Java 21 is possible, but still considered experimental.
Using Java 21 is possible, and will be required for openHAB 5.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Using Java 21 is possible, and will be required for openHAB 5.
Using Java 21 is possible, and required for openHAB 5.

OpenHABian can install Java 21, but only on the native 64-bit image.
Please note that versions of Java other than 17 and 21 are not supported at the moment.

Upcoming openHAB 5 will require Java 21.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Upcoming openHAB 5 will require Java 21.
openHAB 5 requires Java 21.

@@ -46,6 +46,8 @@ You should probably do your usual OS backup too to make sure you can get back to

openHAB (since version 4) requires Java 17. Most modern Linux OS have an `openjdk-17-jdk` package available for you to install but alternative solutions such as [Zulu's OpenJDK](https://www.azul.com/downloads/zulu-community/?version=java-17-lts&package=jdk) (which openHABian can install for you) are available and these may run faster on 32-bit armhf platforms such as the Raspberry Pi.

Upcoming openHAB 5 development requires Java 21.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Upcoming openHAB 5 development requires Java 21.
openHAB 5 development requires Java 21.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #2426 (comment)

@stefan-hoehn
Copy link
Contributor

let me know when you want to have this merged.

@mstormi @ecdye
I actually fell into the trap not knowing that 21 is required for openHAB 5 and when I upgraded to the latest snapshot (5, that is) with openhabian-config it wasn't working (very likely because of jdk 17). Could you detect OH 5 and then automatically upgrade to java 21 or would you prefer a different approach?

@holgerfriedrich
Copy link
Member Author

I will rework this once I find some time. It should have been added before we released 4.3....

@stefan-hoehn Maybe we should have pinned this forum post....
https://community.openhab.org/t/openhab-5-x-snapshot-requires-java-21/160890

@stefan-hoehn
Copy link
Contributor

Maybe we should have pinned this forum post....

You mean, pin it in the forum? Yep, would be good idea. I think only a discourse admin can do it, AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants