Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ThingActions docs for UI-based rules & REST API support #2416

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

florian-h05
Copy link
Contributor

No description provided.

@florian-h05
Copy link
Contributor Author

@lolodomo Can you please have a look?

Copy link

netlify bot commented Dec 1, 2024

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 11ee36a
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/675d4685479c530008cf417c
😎 Deploy Preview https://deploy-preview-2416--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this looks very good. I just noticed a forgotten possible type for output.

developers/bindings/index.md Show resolved Hide resolved
@lolodomo
Copy link
Contributor

@florian-h05 @holgerfriedrich : that would be great to merge before releasing version 4.3.

@florian-h05 florian-h05 marked this pull request as ready for review December 14, 2024 08:49
@holgerfriedrich
Copy link
Member

@lolodomo sorry, can't help here, this is docs repo.... I can only merge in core repo.

@florian-h05
Copy link
Contributor Author

Ping @stefan-hoehn

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefan-hoehn stefan-hoehn added this to the 4.3 milestone Dec 14, 2024
@stefan-hoehn stefan-hoehn merged commit 41a27d6 into openhab:main Dec 14, 2024
5 checks passed
@florian-h05 florian-h05 deleted the thing-actions branch December 14, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants