Revert "Fix addon name localisation before installation (#3908)" #4573
+9
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 708a954 but with some modifications Signed-off-by: Jimmy Tanagra <[email protected]>
This was referenced Jan 21, 2025
Signed-off-by: Jimmy Tanagra <[email protected]>
|
It seems that this "NA" thing now is never going to be used, so I've just removed it completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 708a954
but with some modifications
This PR will use the name and description fields from addons.xml and return that to MainUI via REST. This is a change from before #3908 where the name and description fields from addons.xml were overwritten with "n/a".
This data will be used for:
The addons.xml will be cleaned up so that all name/description fields of all addons contain the actual readable text, not i18n reference tags in this PR: openhab/openhab-addons#18139