Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly catch HttpException when retrieving item #3798

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Correctly catch HttpException when retrieving item #3798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion mobile/src/main/java/org/openhab/habdroid/background/ItemsControlsProviderService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,13 @@ class ItemsControlsProviderService : ControlsProviderService() {
}
val state = when (action) {
is BooleanAction -> {
val item = ItemClient.loadItem(connection, itemName) ?: return ControlAction.RESPONSE_FAIL
val item = try {
ItemClient.loadItem(connection, itemName)
} catch (e: HttpClient.HttpException) {
Log.e(TAG, "Could not determine item type for boolean action", e)
null
} ?: return ControlAction.RESPONSE_FAIL

if (item.isOfTypeOrGroupType(Item.Type.Player)) {
if (action.newState) "PLAY" else "PAUSE"
} else {
Expand Down