Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[basicprofiles] Fix regular comparison of Percent Quantity interpreted as $DELTA_PERCENT check #18121

Merged
merged 2 commits into from
Jan 24, 2025
Merged

[basicprofiles] Fix regular comparison of Percent Quantity interpreted as $DELTA_PERCENT check #18121

merged 2 commits into from
Jan 24, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 18, 2025

Alternative solution to #18091

@jimtng
[basicprofiles] Fix regular comparison of Percent Quantity interprete…
088bade 
…d as

$DELTA_PERCENT check

Signed-off-by: Jimmy Tanagra <[email protected]>
@jimtng jimtng requested a review from J-N-K as a code owner January 18, 2025 13:03
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/state-filter-range-filter-profile/158025/57

@jimtng jimtng mentioned this pull request Jan 18, 2025
Closed
@andrewfg
Copy link
Contributor

See #18122

andrewfg
andrewfg requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change suggested

.../test/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfileTest.java Outdated Show resolved Hide resolved
@andrewfg andrewfg added the enhancement An enhancement or new feature for an existing add-on label Jan 23, 2025
@andrewfg andrewfg mentioned this pull request Jan 23, 2025
Open
andrewfg
andrewfg approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewfg
Copy link
Contributor

Minor suggestion: @jimtng if we agree to proceed with this PR rather than #18091 then perhaps you can copy the initial PR description text from that one to this?

lsiepel
lsiepel approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

From a user perspective i prefer this solution above the other one that was made earlier.

@lsiepel lsiepel merged commit de951f5 into openhab:main Jan 24, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Jan 24, 2025
@jimtng jimtng deleted the statefilter-deltapercent-quantity-percent branch January 24, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@andrewfg andrewfg andrewfg approved these changes

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jimtng @openhab-bot @andrewfg @lsiepel