[benqprojector] Fix response processing for newer projectors #18009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <[email protected]>
mlobstein
added
the
bug
maniac103
reviewed
Dec 31, 2024
|
|
||
| // some projectors need the off command twice to switch off | ||
| if (value == Switch.OFF) { | ||
| sendCommand("pow=off"); |
There was a problem hiding this comment.
Wouldn't this be a bit cleaner/clearer?
if (value == Switch.ON) {
sendCommand("pow=on")
} else {
sendCommand("pow=off");
sendCommand("pow=off");
}
Signed-off-by: Michael Lobstein <[email protected]>
mlobstein
changed the title
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
jlaur
added
rebuild
Signed-off-by: Michael Lobstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17996. The current implementation does not work at all with some newer projectors possibly due to an unexpected carriage return in the projector's response. This PR fixes the issue and also an issue where the off command needed to be sent twice to make the projector turn off.
Test build: https://github.com/mlobstein/openhab-addons/releases/download/v4.3.0-snapshot/org.openhab.binding.benqprojector-4.3.0-SNAPSHOT.jar