Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openhabcloud] Send the correct response status text #17994

Merged
merged 1 commit into from
Dec 28, 2024
Merged

[openhabcloud] Send the correct response status text #17994

merged 1 commit into from
Dec 28, 2024

Conversation

digitaldan
Copy link
Contributor

@digitaldan digitaldan added the work in progress A PR that is not yet ready to be merged label Dec 28, 2024
@digitaldan digitaldan mentioned this pull request Dec 28, 2024
Closed
@digitaldan digitaldan removed the work in progress A PR that is not yet ready to be merged label Dec 28, 2024
@digitaldan
Copy link
Contributor Author

This should also be back ported to 4.3.x

florian-h05
florian-h05 approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
We need @openhab/add-ons-maintainers to merge though.

jlaur
jlaur approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur jlaur merged commit e2571d6 into openhab:main Dec 28, 2024
2 of 3 checks passed
@jlaur jlaur added this to the 5.0 milestone Dec 28, 2024
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Dec 28, 2024
jlaur pushed a commit that referenced this pull request Dec 28, 2024
@digitaldan @jlaur
[openhabcloud] Send the correct response status text (#17994)
f4cdcd8 
Signed-off-by: Dan Cunningham <[email protected]>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

@jlaur jlaur jlaur approved these changes

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@digitaldan @jlaur @florian-h05