[upnpcontrol] Ignore negative volume values #17991
Conversation
Signed-off-by: Stefan Höhn <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
jlaur
changed the title
| @@ -1113,6 +1113,11 @@ private void onValueReceivedVolume(String variable, @Nullable String value) { | |||
| long volume = Long.valueOf(value); | |||
| volume = volume * 100 / config.maxvolume; | |||
|
|
|||
| if (volume < 0) { | |||
There was a problem hiding this comment.
Perhaps this could be checked right after line 1113 to avoid performing any calculations with invalid value?
There was a problem hiding this comment.
In the identified error case, volume came from the service as a negative. But there might also be a case where config.maxvolume (also retrieved from the service) is negative and that would lead to problems as well. Or we catch this bad data where config.maxvolume is set as well, or we leave this statement where it is.
There was a problem hiding this comment.
Too many ORs 😅 So what do we wanna do?
There was a problem hiding this comment.
Move it right after line 1113, but also change here:
Put the following on that line:
if (volume && volume > 0)
In principle, it should be a positive integer less than or equal to 100. You could also log a warning there if it is not.
...trol/src/main/java/org/openhab/binding/upnpcontrol/internal/handler/UpnpRendererHandler.java
Show resolved
Hide resolved
...trol/src/main/java/org/openhab/binding/upnpcontrol/internal/handler/UpnpRendererHandler.java
Show resolved
Hide resolved
I have at least one upnp system that is sending incorrect negative volume values. This change make the binding resilient by ignoring negative volume values.