[insteon] Fix legacy backward compatibility

[jsetton]

This change fixes the legacy backward compatibility for thing textual configuration that I overlooked when working on that implementation.

Unfortunately, the framework is preventing things with channel configuration from going through its initialization process due to the original channel type not being available. This requires the user to update their thing configuration file updating the channel types to the new ones. Reverting to the old ones is not possible as some are conflicting with the new ones.

These include:

• Fixing the missing broadcastOnOff channels when migrating textual configuration.
• Restoring all the original channel characteristics including any custom labels, compared to only the channel configuration previously.
• Removing the previously discovered legacy device from the inbox.
• Fixing a bug in legacy device things where previously linked channels aren't reconnected internally when updated.

These fixes should be included in 4.3.1.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/insteon-broke-on-upgrade-to-4-3/161055/16

[lsiepel]

One question, otherwise LGTM.

As users with file based configuration need to adapt their configuration, it justifies to add a upgrade notice into the distro repository. Can you add a PR there?

[jsetton]

Can you add a PR there?

Done.

[lsiepel]

Thanks, LGTM