Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tesla] Adapt binding to changed API from Tesla backend #14924

Merged
merged 2 commits into from
May 3, 2023

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer commented May 2, 2023

This is #14922 being backported to 3.4.x.

As it wasn't possible to cherry-pick or manually port the changes, I have sync'ed the complete binding code to the 3.4 branch (making sure that everything compiles).

It would probably be worthwhile if someone tests it, before it is being merged:

org.openhab.binding.tesla-3.4.4-SNAPSHOT.zip (rename .zip to .jar)

@kaikreuzer kaikreuzer requested a review from a team May 2, 2023 20:59
@kaikreuzer kaikreuzer requested a review from kgoderis as a code owner May 2, 2023 20:59
@kaikreuzer kaikreuzer added bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch labels May 2, 2023
@thekev
Copy link

thekev commented May 2, 2023

Dropped the jar in my 3.4.3 installation and I have verified climate, odometer and state of charge are now updating. I don't use all the features though. I do have this warning message, which I do not find in logs going back about a week. I also updated from 3.4.1 to 3.4.3 just today, so don't have high confidence it is related to your changes.

[WARN ] [ore.internal.thing.ThingTypeResource] - Cannot find channel type: tesla:allowwakeup

@michi6383
Copy link

Very well done! Thank you! :)

@kaikreuzer
Copy link
Member Author

@thekev No idea what this warning is about - there is indeed no such channel type. In case you have any old link to such a channel, please remove it and I'd hope the warning goes away.

FTR: I've just uploaded a newer version of the binding (as the zip above): It adds missing translations and brings discovery of new vehicles, even if they are asleep.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the backport!

@jlaur jlaur merged commit bf2ce7b into openhab:3.4.x May 3, 2023
@seliSoft
Copy link

seliSoft commented May 5, 2023

@kaikreuzer Could you please take another look, it seems that details like BatteryLevel are not beeing updated (using 3.4.4.202305030715)
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants