Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mrf webhook #8073

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

feat: add mrf webhook #8073

wants to merge 1 commit into from

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Jan 23, 2025

Problem

Closes [insert issue #]

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Features:

  • Details ...

Improvements:

  • Details ...

Bug Fixes:

  • Details ...

Before & After Screenshots

BEFORE:

AFTER:

Tests

Deploy Notes

New environment variables:

  • env var : env var details

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

@datadog-opengovsg
Copy link

Datadog Report

Branch report: exp/mrf-webhook
Commit report: be65752
Test service: formsg

❌ 2 Failed (0 Known Flaky), 2993 Passed, 1 Skipped, 6m 58.43s Total duration (4.65s time saved)

❌ Failed Tests (2)

  • multiresponodent-submision.controller submitMultirespondentForm returns 200 ok when form validation passes and invokes createMultiRespondentFormSubmission and performMultiRespondentPostSubmissionCreateActions - src/app/modules/submission/multirespondent-submission/__tests__/multirespondent-submission.controller.spec.ts

  • multiresponodent-submision.controller updateMultirespondentSubmission returns 200 ok when form validation passes and invokes updateMultiRespondentFormSubmission and performMultiRespondentPostSubmissionUpdateActions - src/app/modules/submission/multirespondent-submission/__tests__/multirespondent-submission.controller.spec.ts - Details

    Expand for error
     expect(received).toEqual(expected) // deep equality
     
     - Expected  - 0
     + Received  + 4
     
     @@ -1,6 +1,7 @@
       Object {
     +   "currentStepNumber": undefined,
         "encryptedPayload": Object {
           "encryptedContent": "encryptedContent",
     ...
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant