-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mfb v1.1 accept-deny re-prompt #7959
base: develop
Are you sure you want to change the base?
Conversation
6187c37
to
8a68323
Compare
Datadog ReportBranch report: ✅ 0 Failed, 119 Passed, 0 Skipped, 27.84s Total duration (6m 32.39s time saved) |
dc41d3a
to
89a3f1c
Compare
Pending unit test for:
Pending chromatic story for:
note: did not write chromatic stories for the highlighted fields indicating accept/deny pending due to difficulties providing decorators for contexts/providers around the component. |
Since can re-prompt, update form metadata to store # of prompts made per form to track volume of usage |
7ca49d6
to
23d5171
Compare
23d5171
to
6394f25
Compare
Datadog ReportBranch report: ✅ 0 Failed, 2178 Passed, 1 Skipped, 5m 4.87s Total duration (1m 58.22s time saved) |
Problem
With MFB v1.0, admins are unable to re-try a prompt if they do not like the results from the initial prompt without recreating a new form or deleting all fields.
This is since when a form is generated using MFB prompt, the fields are created and MFB button disappears as it does not show up when fields exist for a form.
Closes FRM-1925
Solution
Allow admins to accept or reject proposed changes generated by Magic Form Builder.
Breaking Changes
No - this PR is backwards compatible
Before & After Screenshots
BEFORE:
AFTER:
Tests
TC1: Prompt is able to generate fields for empty form and can deny:
drag a field or...
TC2: Prompt is able to generate fields with sample prompts for empty form and can accept:
create field
.TC3: Prompt is able to generate fields for form with fields:
TC4: Can accept/deny even after going out of form
all forms
on the top left to go back to the forms list.all forms
and select the form with the generated fields.TC5: Refresh saves the generated fields