Merge pull request #2409 from opengovern/fix-queries

fix: skip compliance job with failed validator
opengovern · Jan 10, 2025 · ec64414 · ec64414
2 parents 19f822a + 3099129
commit ec64414
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/services/scheduler/schedulers/compliance-quick-run/publisher.go b/services/scheduler/schedulers/compliance-quick-run/publisher.go
@@ -42,7 +42,9 @@ func (s *JobScheduler) runPublisher(ctx context.Context) error {
 			}
 			err = s.ValidateComplianceJob(*framework)
 			if err != nil {
+				s.logger.Error("framework validation failed", zap.String("frameworkID", job.FrameworkID), zap.Error(err))
 				_ = s.db.UpdateComplianceJob(job.ID, model.ComplianceJobFailed, err.Error())
+				continue
 			}
 		}
 

diff --git a/services/scheduler/schedulers/compliance/trigger.go b/services/scheduler/schedulers/compliance/trigger.go
@@ -268,7 +268,9 @@ func (s *JobScheduler) enqueueRunnersCycle() error {
 			}
 			err = s.ValidateComplianceJob(*framework)
 			if err != nil {
+				s.logger.Error("framework validation failed", zap.String("frameworkID", job.FrameworkID), zap.Error(err))
 				_ = s.db.UpdateComplianceJob(job.ID, model.ComplianceJobFailed, err.Error())
+				continue
 			}
 		}
 		s.logger.Info("processing job with unqueued runners", zap.Uint("jobID", job.ID))