Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefix for searching on environment variables #20

Merged
merged 11 commits into from
Dec 27, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 15, 2023

Based on @salehkhazaei request, I am going to remove the prefix searching so we can deploy without changing anything on current deployments.

@ghost ghost requested a review from Mahanmmi December 15, 2023 20:41
@ghost ghost self-assigned this Dec 15, 2023
@1995parham
Copy link

1995parham commented Dec 27, 2023

We decided to consider the env prefix, and the integration service is now using it on production.

@1995parham 1995parham force-pushed the remove-koanf-env-prefix branch from 96d10e7 to 2b5c690 Compare December 27, 2023 05:49
@1995parham 1995parham self-assigned this Dec 27, 2023
@1995parham 1995parham removed the request for review from Mahanmmi December 27, 2023 05:56
@1995parham 1995parham merged commit 18b272a into main Dec 27, 2023
1 check failed
@1995parham 1995parham deleted the remove-koanf-env-prefix branch December 27, 2023 06:00
@1995parham 1995parham removed their assignment Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants