fix: add keyColumns to get configs

opengovern · Dec 9, 2024 · d650abb · d650abb
1 parent b246bf4
commit d650abb
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 9 deletions.
diff --git a/steampipe-plugin-github/github/table_github_community_profile.go b/steampipe-plugin-github/github/table_github_community_profile.go
@@ -13,9 +13,7 @@ func tableGitHubCommunityProfile() *plugin.Table {
 		Name:        "github_community_profile",
 		Description: "Community profile information for the given repository.",
 		List: &plugin.ListConfig{
-			KeyColumns:        plugin.SingleColumn("repository_full_name"),
-			Hydrate:           opengovernance.ListCommunityProfile,
-			ShouldIgnoreError: isNotFoundError([]string{"404"}),
+			Hydrate: opengovernance.ListCommunityProfile,
 		},
 		Columns: commonColumns([]*plugin.Column{
 			{

diff --git a/steampipe-plugin-github/github/table_github_container_package.go b/steampipe-plugin-github/github/table_github_container_package.go
@@ -13,7 +13,8 @@ func tableGitHubContainerPackage() *plugin.Table {
 			Hydrate: opengovernance.ListPackage,
 		},
 		Get: &plugin.GetConfig{
-			Hydrate: opengovernance.GetPackage,
+			KeyColumns: plugin.AllColumns([]string{"id"}),
+			Hydrate:    opengovernance.GetPackage,
 		},
 		Columns: []*plugin.Column{
 			// Basic details columns

diff --git a/steampipe-plugin-github/github/table_github_maven_package.go b/steampipe-plugin-github/github/table_github_maven_package.go
@@ -13,7 +13,8 @@ func tableGitHubMavenPackage() *plugin.Table {
 			Hydrate: opengovernance.ListPackage,
 		},
 		Get: &plugin.GetConfig{
-			Hydrate: opengovernance.GetPackage,
+			KeyColumns: plugin.AllColumns([]string{"id"}),
+			Hydrate:    opengovernance.GetPackage,
 		},
 		Columns: []*plugin.Column{
 			// Basic details columns

diff --git a/steampipe-plugin-github/github/table_github_npm_package.go b/steampipe-plugin-github/github/table_github_npm_package.go
@@ -13,7 +13,8 @@ func tableGitHubNPMPackage() *plugin.Table {
 			Hydrate: opengovernance.ListPackage,
 		},
 		Get: &plugin.GetConfig{
-			Hydrate: opengovernance.GetPackage,
+			KeyColumns: plugin.AllColumns([]string{"id"}),
+			Hydrate:    opengovernance.GetPackage,
 		},
 		Columns: []*plugin.Column{
 			// Basic details columns

diff --git a/steampipe-plugin-github/github/table_github_nuget_package.go b/steampipe-plugin-github/github/table_github_nuget_package.go
@@ -13,7 +13,8 @@ func tableGitHubNugetPackage() *plugin.Table {
 			Hydrate: opengovernance.ListPackage,
 		},
 		Get: &plugin.GetConfig{
-			Hydrate: opengovernance.GetPackage,
+			KeyColumns: plugin.AllColumns([]string{"id"}),
+			Hydrate:    opengovernance.GetPackage,
 		},
 		Columns: []*plugin.Column{
 			// Basic details columns

diff --git a/steampipe-plugin-github/github/table_github_package_version.go b/steampipe-plugin-github/github/table_github_package_version.go
@@ -14,7 +14,8 @@ func tableGitHubPackageVersion() *plugin.Table {
 			Hydrate: opengovernance.ListPackageVersion,
 		},
 		Get: &plugin.GetConfig{
-			Hydrate: opengovernance.GetPackageVersion,
+			KeyColumns: plugin.AllColumns([]string{"id"}),
+			Hydrate:    opengovernance.GetPackageVersion,
 		},
 		Columns: []*plugin.Column{
 			// Basic details columns

diff --git a/steampipe-plugin-github/github/table_github_rubygems_package.go b/steampipe-plugin-github/github/table_github_rubygems_package.go
@@ -13,7 +13,8 @@ func tableGitHubRubyGemsPackage() *plugin.Table {
 			Hydrate: opengovernance.ListPackage,
 		},
 		Get: &plugin.GetConfig{
-			Hydrate: opengovernance.GetPackage,
+			KeyColumns: plugin.AllColumns([]string{"id"}),
+			Hydrate:    opengovernance.GetPackage,
 		},
 		Columns: []*plugin.Column{
 			// Basic details columns