♻️(backends) use common utilities among backends #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
SergioSim
force-pushed
the
generic-data-backends
branch
from
1d6be41 to
20d7114
Compare
SergioSim
force-pushed
the
unify-backend-utilities
branch
from
89b640a to
37a9d32
Compare
This was referenced Nov 13, 2023
SergioSim
force-pushed
the
generic-data-backends
branch
from
20d7114 to
2257aba
Compare
SergioSim
force-pushed
the
unify-backend-utilities
branch
from
37a9d32 to
09baf10
Compare
Leobouloc
reviewed
Nov 14, 2023
Leobouloc
reviewed
Nov 15, 2023
SergioSim
force-pushed
the
generic-data-backends
branch
from
2257aba to
02aed1d
Compare
SergioSim
force-pushed
the
unify-backend-utilities
branch
from
09baf10 to
71e038d
Compare
SergioSim
force-pushed
the
generic-data-backends
branch
from
02aed1d to
525f9c1
Compare
SergioSim
force-pushed
the
unify-backend-utilities
branch
from
1fc4872 to
d5c7d3c
Compare
SergioSim
force-pushed
the
unify-backend-utilities
branch
from
c7b75e3 to
d426d70
Compare
wilbrdt
approved these changes
Nov 23, 2023
SergioSim
force-pushed
the
unify-backend-utilities
branch
5 times, most recently
from
d40480a to
e609c67
Compare
wilbrdt
reviewed
Nov 24, 2023
During data backend unification work some shared utilities were developed to factorize duplication: `parse_dict_to_bytes`, `read_raw` and `iter_by_batch`. However, some backends still used their own implementation of these utilities leading to some minor behavioral differences among backends. Thus, for consistency, we update backends to use common utilities.
SergioSim
force-pushed
the
unify-backend-utilities
branch
from
67b0601 to
89d588d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
During data backend unification work, some shared utilities were developed to factorize duplication:
parse_dict_to_bytes,read_rawanditer_by_batch.However, some backends still used their own implementation of these utilities, leading to some minor behavioral differences among backends.
Proposal
parse_bytes_to_dictmore generic (parse_to_dict) to improve re-usability (see usage in ClickHouseDataBackend).Note: This PR depends on #501