✨(app) generate upload url #18
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add generated upload url when creating a runner_job. It will be used by the runner to upload the video. By default the upload endpoint is pointing to our app, but it the storage inherit from s3, then it will boto3 client to generate the upload url.
kernicPanel
approved these changes
Dec 22, 2023
| @@ -99,6 +99,7 @@ def complete(self, runner_job: RunnerJob, result_payload): | |||
| self.specific_complete(runner_job, result_payload) | |||
| runner_job.state = RunnerJobState.COMPLETED | |||
| except Exception as err: # pylint: disable=broad-except | |||
| print(err) | |||
There was a problem hiding this comment.
Suggested change
| print(err) | |
| print(err) |
Should be removed ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generated upload url when creating a runner_job. It will be used by the runner to upload the video. By default the upload endpoint is pointing to our app, but it the storage inherit from s3, then it will boto3 client to generate the upload url.
It should be used with this Peertube PR.