✨(apps) add elasticsearch application #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmatah
force-pushed
the
feature-elasticsearch-ha
branch
9 times, most recently
from
c7d7b81 to
6d520ea
Compare
madmatah
changed the title
jmaupetit
reviewed
Jan 28, 2020
apps/elasticsearch/templates/services/app/configs/readiness-probe.sh.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/readiness-probe.sh.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/readiness-probe.sh.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/readiness-probe.sh.j2
Outdated
Show resolved
Hide resolved
madmatah
force-pushed
the
feature-elasticsearch-ha
branch
5 times, most recently
from
f107971 to
591f413
Compare
|
@jmaupetit I think I adressed all your feedbacks, thank you very much ! Now let's wait for CI green lights... |
lunika
reviewed
Jan 29, 2020
apps/elasticsearch/templates/services/app/job_set_index_template.yml.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/job_set_index_template.yml.j2
Outdated
Show resolved
Hide resolved
|
@madmatah great! I'll give this PR a new review. |
jmaupetit
reviewed
Jan 29, 2020
apps/elasticsearch/templates/services/app/configs/elasticsearch.yml.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/readiness-probe.sh.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/readiness-probe.sh.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/readiness-probe.sh.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/readiness-probe.sh.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/set-index-template.sh.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/set-index-template.sh.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/set-index-template.sh.j2
Outdated
Show resolved
Hide resolved
madmatah
force-pushed
the
feature-elasticsearch-ha
branch
2 times, most recently
from
5a915b1 to
815a9be
Compare
|
Done ! It's better with the json file in the ConfigMap. |
jmaupetit
reviewed
Jan 29, 2020
apps/elasticsearch/templates/services/app/configs/elasticsearch.yml.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/elasticsearch.yml.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/set-index-template.sh.j2
Outdated
Show resolved
Hide resolved
apps/elasticsearch/templates/services/app/configs/set-index-template.sh.j2
Outdated
Show resolved
Hide resolved
madmatah
force-pushed
the
feature-elasticsearch-ha
branch
3 times, most recently
from
150b729 to
0497398
Compare
|
Fixed and rebased ! |
Add an independant elasticsearch app with a configurable high availability cluster. It is designed to run without persistent volume and it supports rolling updates without any data loss. On the other hand, a full restart of the ES cluster (without rolling update) results in data loss and requires to recreate indexes.
madmatah
force-pushed
the
feature-elasticsearch-ha
branch
from
0497398 to
46465a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As described in #419 :
Proposal
Add an independant elasticsearch app with a configurable high availability cluster. It is designed to run without persistent volume and it supports rolling updates without any data loss.
On the other hand, a full restart of the ES cluster (without rolling update) results in data loss and requires to recreate indexes.