introduce modularity in our playbooks #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to execute task form the app repository at a precise moment in our playbooks. To do that this two tasks can be executed and will include tasks if they found them
Create_vaults playbook is the first where we need a hook.
|
I like the idea, but I think we must talk a bit more of what must be achieved first. This implies dependencies between applications. IMO that should be implemented first. |
|
This PR is a POC and I'm open to discuss about what can be implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In #175 we want to execute a task depending on a context and specific to an app. So we need to be able to execute tasks that are "application centric".
Proposal
Create a "hook" system. Tasks can live in the application folder and will be executed if they follow a pattern we choose. You should create a
hooksfolder and then in it files with the name of the hook you want to implement. For example for the hookvaults_createdyou should create this file for the forum application:apps/forum/hooks/vaults_created.yml