Add deployment tests workflow #207
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
mattwthompson
force-pushed
the
add-deployment-action
branch
from
ad55f83
to
8e56f45
Compare
mattwthompson
force-pushed
the
add-deployment-action
branch
from
07bb689
to
0ab00b3
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
mattwthompson
force-pushed
the
add-deployment-action
branch
from
899a5d6
to
0cd73f0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Hey @mattwthompson, sorry I'm only just now getting around to this. I have no idea what's going on here - the test passes locally with the new deployment environment, and I'm just seeing what happens when I try the entire test suite now. I don't even know what It looks like the 0.2.0 release is broken - #213 - which was apparently not detected by tests. I think we need some full on integration tests where we try to run an entire fit - the current unit tests don't seem to cut it. So these deployment tests are definitely important and good! |
|
| I think we need some full on integration tests where we try to run an entire fit Yes I think we do it looks like this test should have picked up on the forcebalance incompatibility but has been mocked probably to try and reduce the CI time but I think its more important that its tested? |
|
Another test is crashing now - I wonder if the problem is that the CI environment is headless? Both crashing tests have "image" in the name. But not sure why tests would pass in regular CI but not here. |
|
I think it was an openeye license issue. I saw this in the log that failed |
# This is the 1st commit message: Add deployment tests # This is the commit message #2: Update # This is the commit message #3: Fix # This is the commit message #4: Trim down differences between environments # This is the commit message #5: Try to isolate crash # This is the commit message #6: Rename environment # This is the commit message #7: Further pare down environments # This is the commit message #8: Bump Python version # This is the commit message #9: Update environments # This is the commit message #10: Double check OpenEye license
Update Fix Trim down differences between environments Try to isolate crash Rename environment Further pare down environments Bump Python version Update environments Double check OpenEye license Skip crashing test
author Matthew W. Thompson <[email protected]> 1673977806 -0600 committer Matthew W. Thompson <[email protected]> 1673977819 -0600 Add deployment tests Update Fix Trim down differences between environments Try to isolate crash Rename environment Further pare down environments Bump Python version Update environments Double check OpenEye license Skip crashing test Skip another crashing test Tinker with OpenEye config Update Psi4 installation instructions Assume version 0.1.3
mattwthompson
force-pushed
the
add-deployment-action
branch
from
905c946
to
96e6d0e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks Matt - Looks like the geometric issues were fixed in #243 by pinning Geometric=1. Now that 0.2.1 is out, I've updated this to use it - and things seem to be working! |
There was a problem hiding this comment.
Looks good @mattwthompson, just trying out some polishes. Will approve+merge once I see if these work, so nothing more needed from you. Thanks!
Description
This PR adds deployment tests ("conda tests")
Status