Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rubocop Rails/ResponseParseBody #13112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix rubocop Rails/ResponseParseBody #13112

wants to merge 2 commits into from

Conversation

Yassir4
Copy link

@Yassir4 Yassir4 commented Jan 31, 2025

What? Why?

Note

I disabled the RuboCop check on the spec/controllers/user_registrations_controller_spec.rb because the response is returned using format.js not format.json which doesn't work well with the parsed_body method.

What should we test?

  • Test should pass for the spec file changed

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Yassir4 Yassir4

Labels
None yet
Projects
OFN Delivery board
Status: Code review 🔎
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rubocop Rails/ResponseParsedBody
1 participant
@Yassir4