Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Knowledge panel page: shortcuts to edit mode #6268

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 22, 2025

Hi everyone!

I've added shortcuts to:

  • ingredients
  • packaging
  • origins

I think the three dots are less confusing and they allow us to add new items (e.g.: flag something)

Untitled

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 6.02%. Comparing base (4d9c7fc) to head (8cc36b0).
Report is 694 commits behind head on develop.

Files with missing lines Patch % Lines
...e_panel/knowledge_panels/knowledge_panel_page.dart 0.00% 61 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6268      +/-   ##
==========================================
- Coverage     9.54%   6.02%   -3.53%     
==========================================
  Files          325     469     +144     
  Lines        16411   27471   +11060     
==========================================
+ Hits          1567    1656      +89     
- Misses       14844   25815   +10971     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit ebcbe32 into openfoodfacts:develop Jan 22, 2025
6 checks passed
@g123k g123k deleted the kp_shortcuts branch January 22, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants