Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tagline: support "min_launches" attribute #6236

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 19, 2025

Hi everyone!

We have complaints about the donation campaign from new users (= asked too early).
News in the tagline can now provide a min_launches attribute = min launches of the app.

cf https://github.com/openfoodfacts/smooth-app_assets/pull/8/files

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 6.21%. Comparing base (4d9c7fc) to head (43b2015).
Report is 674 commits behind head on develop.

Files with missing lines Patch % Lines
...h_app/lib/data_models/news_feed/newsfeed_json.dart 0.00% 9 Missing ⚠️
...p/lib/data_models/news_feed/newsfeed_provider.dart 0.00% 2 Missing ⚠️
..._app/lib/data_models/news_feed/newsfeed_model.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6236      +/-   ##
==========================================
- Coverage     9.54%   6.21%   -3.34%     
==========================================
  Files          325     456     +131     
  Lines        16411   26716   +10305     
==========================================
+ Hits          1567    1660      +93     
- Misses       14844   25056   +10212     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 40ce1fa into openfoodfacts:develop Jan 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants