Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5817 Product page: tab Data #5953

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

AdrienMDevMobile
Copy link

@AdrienMDevMobile AdrienMDevMobile commented Nov 27, 2024

What

  • feat 5814 : Product page: tab data

Screenshot

Fixes bug(s)

  • Fixes:

Part of

@AdrienMDevMobile AdrienMDevMobile changed the title Feat: 5817 Product page: tab Data feat: 5817 Product page: tab Data Nov 27, 2024
@AdrienMDevMobile
Copy link
Author

@g123k could you tell me please, if squash on merge is allowed on this project ?

@g123k
Copy link
Collaborator

g123k commented Nov 27, 2024

@g123k could you tell me please, if squash on merge is allowed on this project ?

Yes, that's what we do:
Screenshot 2024-11-27 at 17 32 13

@teolemon
Copy link
Member

info • To-do comment doesn't follow the Flutter style • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_category_item.dart:98:26 • flutter_style_todos
   info • Unnecessary use of double quotes • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_element_item.dart:19:29 • prefer_single_quotes
   info • To-do comment doesn't follow the Flutter style • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_element_item.dart:19:44 • flutter_style_todos
   info • Use 'const' with the constructor to improve performance • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:22:31 • prefer_const_constructors
   info • Unnecessary use of double quotes • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:22:36 • prefer_single_quotes
   info • Use 'const' with the constructor to improve performance • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:24:26 • prefer_const_constructors
   info • To-do comment doesn't follow the Flutter style • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:24:63 • flutter_style_todos
   info • A value for optional parameter 'controller' isn't ever given • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:29:49 • unused_element
   info • Use 'const' with the constructor to improve performance • packages/smooth_app/lib/pages/product/product_page/raw_data/product_raw_data_page.dart:40:[11](https://github.com/openfoodfacts/smooth-app/actions/runs/12053739973/job/33610932110?pr=5953#step:8:12) • prefer_const_constructors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

3 participants