Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix regressions after Material 3 migration #5740

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Oct 26, 2024

Hi everyone!

This PR fixes three things:

  • The white-on-white button in dark mode (@see Dark mode issue #5738)
  • The same buttons now have a bolder font
  • Add a shadow to the BottomNavigationBar

IMG_42A7D541749C-1
IMG_42A7D541749C-2

@github-actions github-actions bot added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Oct 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 6.96%. Comparing base (4d9c7fc) to head (3dc33a0).
Report is 394 commits behind head on develop.

Files with missing lines Patch % Lines
packages/smooth_app/lib/pages/page_manager.dart 0.00% 19 Missing ⚠️
...ackages/smooth_app/lib/pages/scan/scan_header.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5740      +/-   ##
==========================================
- Coverage     9.54%   6.96%   -2.58%     
==========================================
  Files          325     407      +82     
  Lines        16411   21782    +5371     
==========================================
- Hits          1567    1518      -49     
- Misses       14844   20264    +5420     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy fix @g123k 👌

@teolemon teolemon merged commit 40a8641 into openfoodfacts:develop Oct 27, 2024
6 checks passed
@g123k g123k deleted the material3_fix branch November 7, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging this pull request may close these issues.

4 participants