-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Missing birthday cake for new products #5651
base: develop
Are you sure you want to change the base?
Conversation
The illustration has an issue because the candles are white on white. |
yes thats an issue with the svg itself...do you have an alternate svg or do you want me to tweak its colors a bit? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5651 +/- ##
==========================================
- Coverage 9.54% 6.87% -2.68%
==========================================
Files 325 402 +77
Lines 16411 21316 +4905
==========================================
- Hits 1567 1466 -101
- Misses 14844 19850 +5006 ☔ View full report in Codecov by Sentry. |
I think the dark background on a white dialog is even more distracting. I'm no designer, maybe someone on the openfoodfacts Slack #design is interested in providing a altered version. Maybe one for light and one for dark background |
What
Screenshot