feat: added dialog if users click on unselect image button #2427 #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts#2427 Signed-off-by: BhuvanAde <[email protected]>
|
@monsieurtanuki Please review this PR. I have fixed the suggested changes. Please let me know if there is anything to change |
|
@BhuvanAde remove the unused imports from the code ! That's why pre submit tests are failing |
packages/smooth_app/lib/pages/product/product_image_viewer.dart
Outdated
Show resolved
Hide resolved
packages/smooth_app/lib/pages/product/product_image_viewer.dart
Outdated
Show resolved
Hide resolved
|
@monsieurtanuki. Sorry for the inconvenience. Please take a look at these. |
monsieurtanuki
approved these changes
Feb 14, 2023
| @@ -164,7 +166,7 @@ class _ProductImageViewerState extends State<ProductImageViewer> { | |||
| EditImageButton( | |||
| iconData: Icons.do_disturb_on, | |||
| label: appLocalizations.edit_photo_unselect_button_label, | |||
| onPressed: _actionUnselect, | |||
| onPressed: () => _actionUnselect(appLocalizations), | |||
There was a problem hiding this comment.
Not sure of the added value to make this call different from the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: BhuvanAde [email protected]
What
app_en.arScreenshot
Fixes bug(s)
#2427
Part of