Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create privacy.html #534

Merged
merged 4 commits into from
Feb 7, 2024
Merged

feat: Create privacy.html #534

merged 4 commits into from
Feb 7, 2024

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Feb 7, 2024

What

  • feat: Create privacy.html

alexgarel
alexgarel requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are problems with the layout.

lang/en/texts/privacy.html Outdated
Comment on lines 12 to 16
<ol start="1">
<li>
<h1>Introduction</h1>
</li>
</ol>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not allowed to put an h1 inside a ol/li.

Moreover it does not output as you would expect:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you even have the summary which is displayed after Introduction, I don't know why !

lang/en/texts/privacy.html Outdated
<li>Authentication by SSH key, access to servers limited to a small trusted group, limitation of the attack surface, use of firewalls, etc.</li>
</ul>
<ol start="7">
<li>How to exercise your rights?&nbsp;</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a h1

lang/en/texts/privacy.html Outdated
<h1>What are your rights ?</h1>
</li>
</ol>
<p>The right of access and to information</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and other below have to be h2

teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
alexgarel
alexgarel approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve to unblock you when fix are done.

teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
teolemon
teolemon commented Feb 7, 2024
View reviewed changes
lang/en/texts/privacy.html Outdated Show resolved Hide resolved
@teolemon teolemon merged commit 17a371b into main Feb 7, 2024
3 checks passed
@teolemon teolemon deleted the teolemon-patch-2 branch February 7, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesNepote CharlesNepote CharlesNepote approved these changes

@alexgarel alexgarel alexgarel approved these changes

Assignees

@teolemon teolemon

Labels
None yet
Projects
📢 Open Food Facts Marketing
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teolemon @alexgarel @CharlesNepote